Skip to content

Conversation

smoshiur1237
Copy link
Contributor

@smoshiur1237 smoshiur1237 commented Oct 6, 2025

DWARF is mostly needed when we are using Delve. DWARF was originally created for C language and the need for it in go and other debugging features is very small in general. As such, switch to using -ldflags="-s -w" by default and have an option to opt in for debugging info for those who would really need it. We are able to reduce almost 30mb image size

Original version
cluster-api-provider-openstack$ docker images gcr.io/k8s-staging-capi-openstack/capi-openstack-controller-amd64
REPOSITORY                                                          TAG       IMAGE ID         SIZE
gcr.io/k8s-staging-capi-openstack/capi-openstack-controller-amd64   dev       e7ed43be0c1f     89.2MB
After this PR change
cluster-api-provider-openstack$ docker images gcr.io/k8s-staging-capi-openstack/capi-openstack-controller-amd64
REPOSITORY                                                          TAG       IMAGE ID         SIZE
gcr.io/k8s-staging-capi-openstack/capi-openstack-controller-amd64   dev       ad5bf2646b53     62.1MB 

Ref: CAPM3

Copy link

netlify bot commented Oct 6, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit a590af8
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68e3989f0e3e58000859d8c4
😎 Deploy Preview https://deploy-preview-2750--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 6, 2025
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@fmuyassarov you are org member and know this well considering that you did it for CAPM3, could you please review and LGTM?
/cc @fmuyassarov

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2025
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @smoshiur1237

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit f3d8d67 into kubernetes-sigs:main Oct 6, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants